Change Wisps to drop with getDrops#1402
Open
JoshieGemFinder wants to merge 2 commits intoAngry-Pixel:1.12-fixesfrom
Open
Change Wisps to drop with getDrops#1402JoshieGemFinder wants to merge 2 commits intoAngry-Pixel:1.12-fixesfrom
JoshieGemFinder wants to merge 2 commits intoAngry-Pixel:1.12-fixesfrom
Conversation
Mainly for compatibility with other mods (e.g. an automatic breaker that captures the drops of the blocks it breaks) Also, this should properly interact with the `doTileDrops` gamerule
Collaborator
Author
|
Where I currently am I cannot properly test how this would interact with pistons et cetera, so I will have to test that when I am able to. If it has unintended side effects that I cannot fix, I will close the pull request. |
Simply adding a check for harvesters to keep the mechanics consistent with explosions and pistons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly for compatibility with other mods (e.g. an enchantment that automatically captures drops from broken blocks and places them in the user's inventory)
Also, this should properly interact with the
doTileDropsgamerule